Skip to content

String(_, radix:): fix documentation #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

PatrickPijnappel
Copy link
Contributor

The parsing regex listed in String(_, radix:) is incorrect.

The parsing regex listed in String(_, radix:) is incorrect.
@PatrickPijnappel
Copy link
Contributor Author

Actually the the exact regex for the code as is seems to be (-+?|+?)[0-9a-zA-Z]*|-*0). It seems unlikely this is by design, and contradicts the documentation by not returning nil in those cases.

@gribozavr gribozavr changed the title Fix documentation String(_, radix:): fix documentation Dec 10, 2015
gribozavr added a commit that referenced this pull request Dec 10, 2015
String(_, radix:): fix documentation
@gribozavr gribozavr merged commit 81431b6 into swiftlang:master Dec 10, 2015
@gribozavr
Copy link
Contributor

@PatrickPijnappel Could you file an issue for that? https://bugs.swift.org/

@PatrickPijnappel
Copy link
Contributor Author

@gribozavr
Copy link
Contributor

Thanks!

@PatrickPijnappel PatrickPijnappel deleted the patch-1 branch December 12, 2015 13:12
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
build: fix clang-cl exception flags
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants