Add support for @Concurrent attribute on closures. #36012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
reviewed
Feb 17, 2021
| @@ -118,3 +118,10 @@ func testCaseNonTrivialValue() { | |||
|
|
|||
| j = 17 | |||
| } | |||
|
|
|||
| func testExplicitConcurrentClosure() { | |||
| let fn = { @concurrent in | |||
There was a problem hiding this comment.
Can you also add some tests that combine @concurrent with parameter names, throws, async, and/or a return type?
There was a problem hiding this comment.
(It'll be a follow-up PR)
slavapestov
reviewed
Feb 17, 2021
|
|
||
| void visitConcurrentAttr(ConcurrentAttr *attr) { | ||
| // Nothing else to check. |
There was a problem hiding this comment.
Do we also need to check if the parameter types and result type are ConcurrentValue, or is that not implemented for functions yet either?
There was a problem hiding this comment.
We've determined that we don't need that checking, because the act of calling a@concurrent function doesn't necessarily make it share its arguments or result value across different concurrency domains. It's the actual capture of non-concurrent values that is the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to specify
@concurrenton closures, e.g.,