[CSFix] Handle some cases where the same fix appears in multiple solutions #36045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that different overload choices could have the same conformance requirement, so diagnostics should be able to emit an error in situations where multiple solutions point to the missing conformance at the same location (both in AST and requirement list). Resolves: rdar://74447308
… solutions If multiple solutions have exactly a fix for exactly the same invalid member reference in key path, let's diagnose that as if there is no ambiguity there.
…cases Is the same argument is out-of-order in multiple solutions, let's diagnose it as if there was no ambiguity. Resolves: SR-14093 Resolves: rdar://73600328
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samein this context means located in the same position and having exactly the same information e.g. same requirement/non-conforming type, same argument positions, same member declaration etc.Resolves: SR-14093
Resolves: rdar://73600328
Resolves: rdar://74447308