Skip to content

SILGen/ClangImporter: Handle async imports with a boolean error flag argument. #36061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2021
Merged

SILGen/ClangImporter: Handle async imports with a boolean error flag argument. #36061

merged 2 commits into from
Feb 23, 2021

Conversation

jckarter
Copy link
Contributor

Import APIs with the swift_async_error attribute in zero_argument or nonzero_argument
modes by checking the corresponding boolean argument to indicate the error status, instead of
treating it as part of the result tuple. rdar://70594666

@jckarter jckarter requested a review from DougGregor February 20, 2021 00:53
@jckarter
SILGen/ClangImporter: Handle async imports with a boolean error flag …
4bb49ba 
…argument.

Import APIs with the `swift_async_error` attribute in `zero_argument` or `nonzero_argument`
modes by checking the corresponding boolean argument to indicate the error status, instead of
treating it as part of the result tuple. rdar://70594666
@jckarter jckarter force-pushed the foreign-async-flag-silgen branch from aad21d7 to 4bb49ba Compare February 20, 2021 01:31
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4bb49ba

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4bb49ba

@jckarter
Copy link
Contributor Author

@swift-ci Please clean test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4bb49ba

@jckarter
Copy link
Contributor Author

@swift-ci Please build toolchain

@jckarter
Copy link
Contributor Author

@swift-ci Please test OS X

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 4bb49ba

Install command
tar zxf swift-PR-36061-559-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4bb49ba

@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - dc4c1ae8fc13e563f9bcc6f4ced865f74d2e068f

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - dc4c1ae8fc13e563f9bcc6f4ced865f74d2e068f

@jckarter jckarter force-pushed the foreign-async-flag-silgen branch from dc4c1ae to fb199df Compare February 23, 2021 16:57
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - fb199df

@DougGregor
Copy link
Member

@swift-ci please test Linux

@DougGregor DougGregor merged commit 4716371 into swiftlang:main Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

@Narin4488 Narin4488 Narin4488 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jckarter @swift-ci @DougGregor @Narin4488