Skip to content

[stdlib] Reinstate some tests #36072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

[stdlib] Reinstate some tests #36072

merged 1 commit into from
Mar 2, 2021

Conversation

benrimmington
Copy link
Contributor

@benrimmington benrimmington commented Feb 21, 2021 •
edited
Loading

Follow-up to: #23423

I've tested (on macOS 11.2.1 and Xcode 12.4) with:

utils/run-test \
  --build-dir ../build/Ninja-RelWithDebInfoAssert \
  --verbose \
  test/stdlib/CodableTests.swift \
  test/stdlib/FloatingPoint.swift.gyb \
  test/stdlib/SetTrapsObjC.swift \
  validation-test/stdlib/DictionaryTrapsObjC.swift

I've replaced multi-line substitutions with one of:

// RUN: %target-run-simple-swift(...)
// RUN: %target-run-simple-swiftgyb(...)

I've marked the remaining test failures with one of:

// FIXME: <rdar://problem/49026133>
// FIXME: <rdar://problem/48917925>
// FIXME: <https://bugs.swift.org/browse/SR-14282>

@benrimmington
Copy link
Contributor Author

@swift-ci Please test

@benrimmington benrimmington mentioned this pull request Feb 21, 2021
Closed
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 42a227abc3ef6ea8fa1a00d69e26e4d20b9a5d44

@benrimmington
Copy link
Contributor Author 

Failed Tests (1):
  Swift(watchsimulator-i386) :: IRGen/marker_protocol.swift

@benrimmington
Copy link
Contributor Author

@swift-ci Please test macOS platform

@benrimmington
Copy link
Contributor Author

@swift-ci Please test Windows platform

@benrimmington
Copy link
Contributor Author 

Failed Tests (2):
  Swift(windows-x86_64) :: SILOptimizer/definite-init-wrongscope.swift
  Swift(windows-x86_64) :: IRGen/marker_protocol.swift

@benrimmington
Copy link
Contributor Author

@swift-ci Please test Windows platform

lorentey
lorentey approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, thank you so much for working on this!

validation-test/stdlib/DictionaryTrapsObjC.swift
@@ -205,6 +198,10 @@ DictionaryTraps.test("ForcedNonverbatimBridge.Value")
_ = d1 as! Dictionary<NSObject, String>
}

// FIXME: <rdar://problem/49026133>
// Segmentation fault: 11 (when compiling with optimizations).
// While running pass #0 SILModuleTransform "SILGenCleanup".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm frustratingly, this compiler crash is a new issue that is unrelated to the original problem (which was a runtime abort() call in the *_debug.sanity tests). Serves us right for leaving this test disabled for so long... 😞

If you still have a crash log handy, could you please file a bug for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you still have a crash log handy, could you please file a bug for it?

I've filed SR-14282.

test/stdlib/FloatingPoint.swift.gyb Outdated
expectTrue(max.isQuietNaN)
expectTrue(minMag.isQuietNaN)
expectTrue(maxMag.isQuietNaN)
// FIXME: <rdar://problem/49026133>
Copy link
Member

@lorentey lorentey Feb 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cc @stephentyrone -- He has been tracking this. (rdar://48917925)

test/stdlib/CodableTests.swift
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the copyright header?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restored the copyright header, with the correct years.
(However, the majority of stdlib tests don't have copyright headers.)

@benrimmington
Copy link
Contributor Author

@swift-ci Please test

@benrimmington benrimmington merged commit 5be886f into swiftlang:main Mar 2, 2021
@benrimmington benrimmington deleted the rdar49026133 branch March 2, 2021 18:13
@benrimmington benrimmington mentioned this pull request Mar 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentey lorentey lorentey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benrimmington @swift-ci @lorentey