Progress towards storing task/executor state in thread-local storage #36079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
NFC except that I added swift_errorRetain and swift_errorRelease functions on non-ObjC targets so that we have consistent functions to call in the runtime. I have not changed everywhere in the runtime to use these, nor have I changed the compiler to call them.
First, just call an async -> T function instead of forcing the caller to piece together which case we're in and perform its own copy. This ensures that the task is actually kept alive properly. Second, now that we no longer implicitly depend on the waiting tasks being run synchronously, go ahead and schedule them to run on the global executor. This solves some problems which were blocking the work on TLS-ifying the task/executor state.
r11 is the linker scratch register, so we need to make sure that we don't end up in the linker when making cross-library direct async calls. Since there are currently only a few special symbols that we do that for, we can achieve this by disabling lazy binding for those symbols specifically.
|
@swift-ci Please test |
rjmccall
force-pushed
the
thread-local-task-state
branch
from
fd43618 to
fd96f41
Compare
|
Build failed |
|
Build failed |
|
I think that this change may have further regressed the Windows CI: https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/4429/console @shahmishal - seems that the CI didn't trigger here? |
ktoso
reviewed
Feb 22, 2021
| trackingInfo.leave(); | ||
| } | ||
|
|
||
| void swift::runJobInExecutorContext(Job *job, ExecutorRef executor) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.