Skip to content

[Foundation] Update CharacterSet and NSCharacterSet punctuationCharac… #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2016

Conversation

phausler
Copy link
Contributor

What's in this pull request?

CharacterSet and NSCharacterSet for the predefined character sets all are plural naming except punctuation, API review concurs that a punctuationCharacters is a more descriptive and consistent name.

Resolved bug number: (SR-)

rdar://problem/26628434 Swift3: "whitespaces"?


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

…ters to more consistent naming

Addresses rdar://problem/26628434 Swift3: "whitespaces"?

…ters to more consistent naming

Addresses rdar://problem/26628434 Swift3: "whitespaces"?
@phausler
Copy link
Contributor Author

@swift-ci Please test

@parkera parkera merged commit a047075 into swiftlang:master Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants