[SymbolGraph] don't emit navigator name if it's the same as subHeading #36095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuietMisdreavus
force-pushed
the
QuietMisdreavus/duplicate-navigator-subheading
branch
from
239e291 to
495732e
Compare
|
@swift-ci Please smoke test |
QuietMisdreavus
force-pushed
the
QuietMisdreavus/duplicate-navigator-subheading
branch
from
495732e to
db3685a
Compare
QuietMisdreavus
changed the title
|
After speaking with the person who reported this issue, it turns out i misunderstood the way the format was used; the @swift-ci Please smoke test |
|
@swift-ci Smoke test Windows Platform |
|
The Windows test failure seems to be SR-12376. I'm going to go ahead and merge since macOS and Linux both passed. |
QuietMisdreavus
deleted the
QuietMisdreavus/duplicate-navigator-subheading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://70202693
When rendering a symbol graph, often there are situations where the
namesobject has duplicate information in thenavigatorandsubHeadingfield. Since the fields ofnamescan cascade fromsubHeadingtonavigatorwhen the latter is absent, choosing to omit this field in this situation can decrease the size of the symbol graph with no loss of data.