Skip to content

Fix a couple of cases of infinite recursion #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2015
Merged

Fix a couple of cases of infinite recursion #361

merged 2 commits into from
Dec 10, 2015

Conversation

dcci
Copy link
Member

@dcci dcci commented Dec 9, 2015

I'm not really familiar with this code yet but I hope they make sense to you.

@dcci
Copy link
Member Author

dcci commented Dec 9, 2015

My original intent was that of silencing a clang warning (with -Winfinite-recursion)
warning: all paths through this function will call itself [-Winfinite-recursion].
I don't currently have a working swift compiler as porting to FreeBSD is still a WIP.
Maybe this can wait until I get something working (or somebody else writes a test for this).

@lattner
Copy link
Contributor

lattner commented Dec 10, 2015

This patch looks fine to me. There is no way to write a testcase for this since the functions are apparently dead. A better patch might be to just remove them, but in the absence of that, making them correct seems fine. Thanks!

lattner added a commit that referenced this pull request Dec 10, 2015
Fix a couple of cases of infinite recursion
@lattner lattner merged commit c5bfaa4 into swiftlang:master Dec 10, 2015
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
build: support system installed BlocksRuntime
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants