[Frontend] Allow missing files when allowing compiler errors #36105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@rintaro this changes the old SourceKit behaviour slightly - ie. it now allows an empty primary file as well. I know this is useless for SourceKit itself, but I figured it's one less branch to maintain and doesn't cause any test failures that I saw. Does that seem okay to you? |
CodaFi
approved these changes
Feb 23, 2021
rintaro
approved these changes
Feb 23, 2021
bnbarham
force-pushed
the
allow-missing-files
branch
from
76000a8 to
42ea4d1
Compare
|
Apparently the error on windows has a lower case, I've just changed the tests to check for just "error opening input file" instead. @swift-ci please test |
As with other compilation errors, we want to generate the swiftmodule regardless.
bnbarham
force-pushed
the
allow-missing-files
branch
from
42ea4d1 to
bb9dd3a
Compare
|
I missed two of the error checks :( @swift-ci please test Windows platform |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with other compilation errors, we want to generate the swiftmodule
regardless.