Add Real Enable/Disable Flags for Cross-Module Incremental Builds #36111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
CodaFi
commented
Feb 23, 2021
include/swift/Option/Options.td
Outdated
| def disable_incremental_imports : | ||
| Flag<["-"], "disable-incremental-imports">, | ||
| Flags<[FrontendOption]>, | ||
| HelpText<"Enable cross-module incremental build metadata and " |
CodaFi
force-pushed
the
cross-over-episode
branch
from
a9280e7 to
d2be9e4
Compare
davidungar
approved these changes
Feb 23, 2021
|
@swift-ci smoke test |
CodaFi
force-pushed
the
cross-over-episode
branch
2 times, most recently
from
77633b4 to
8826ef1
Compare
In the legacy driver, these flags will merely be propagated to the frontends to indicate that they should disable serialization of incremental information in swift module files. In the new driver, these flags control whether the Swift driver performs an incremental build that is aware of metadata embedded in the module. Kudos to David for coming up with our new marketing name: Incremental Imports. rdar://74363450
CodaFi
force-pushed
the
cross-over-episode
branch
from
8826ef1 to
28a37a4
Compare
Now that incremental imports are the default, flip the polarity in some tests.
Make sure we can effectively turn this feature off instead of on.
|
@swift-ci smoke test |
CodaFi
force-pushed
the
cross-over-episode
branch
from
2550df2 to
714a871
Compare
|
@swift-ci smoke test |
CodaFi
force-pushed
the
cross-over-episode
branch
from
714a871 to
d946df7
Compare
|
@swift-ci smoke test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the legacy driver, these flags will merely be propagated to the frontends to indicate that they should disable serialization of incremental information in swift module files.
In the new driver, these flags control whether the Swift driver performs an incremental build that is aware of metadata embedded in the module.
Kudos to David for coming up with our new marketing name: Incremental Imports.
For now, I am not removing the option to provide the old experimental flag. Once we re-run the options generation script in the new driver, I will be removing it.
rdar://74363450