[AutoDiff] Remove 'withoutDerivative(at:in:)' and 'withDerivative(_:)'. #36124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `move(along:)` to `move(by:)` based on the proposal feedback. The main argument for the change is that tangent vectors specify both a direction and a magnitude, whereas `along:` does not indicate that `self` is being moved by the specified magnitude.
|
Please review 67e84b6. |
|
@swift-ci please smoke test and merge |
dan-zheng
approved these changes
Feb 24, 2021
Rename the argument label `in:` in `gradient(at:in:)`, `pullback(at:in:)`, etc to `of:`, as suggested in the [pitch thread](https://forums.swift.org/t/differentiable-programming-for-gradient-based-machine-learning/42147).
These APIs are not included in the initial proposal.
rxwei
force-pushed
the
remove-withderivative
branch
from
67e84b6 to
17cf272
Compare
|
@swift-ci please smoke test and merge |
|
I'd just like to say that there are some Autodiff bugs that require workarounds using There may be reasons (scope of the current proposal (?)) to remove it, and it is technically re-definable by users, but from a beginner's standpoint, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These APIs are not included in the initial proposal. This PR moves them to
DifferentiationUnittests.