Skip to content

C++ Interop: cleanup operator tests (NFC) #36144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

C++ Interop: cleanup operator tests (NFC) #36144

merged 1 commit into from
Mar 2, 2021

Conversation

egorzhdan
Copy link
Contributor

Rename the test structures to match the terminology of loadable types vs address-only types.

#36075 (comment)

@egorzhdan egorzhdan marked this pull request as ready for review February 24, 2021 22:20
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan marked this pull request as draft February 24, 2021 22:25
@egorzhdan
Copy link
Contributor Author

egorzhdan commented Feb 25, 2021 •
edited
Loading

@swift-ci please test Windows platform
Hmm, that doesn't seem to work...

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Feb 25, 2021
@egorzhdan egorzhdan marked this pull request as ready for review February 25, 2021 09:14
@egorzhdan egorzhdan requested a review from zoecarver February 25, 2021 09:14
zoecarver
zoecarver approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@zoecarver zoecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thank you for the cleanup! 🚢 it.

@zoecarver
Copy link
Contributor

@swift-ci please test Windows platform

@zoecarver
Copy link
Contributor

IIUC, the swift-ci please test Windows platform needs to be the last (or only) thing in the comment.

@egorzhdan
Copy link
Contributor Author

IIUC, the swift-ci please test Windows platform needs to be the last (or only) thing in the comment.

Yeah I've tried that and a bunch of other commands like swift-ci please test Windows without platform, but none of them worked & I removed them all.
Anyway, the CI seems to work now, so that must have been a fluke.

@egorzhdan
Copy link
Contributor Author

...and the failure is unrelated. Let's try again.

@egorzhdan
Copy link
Contributor Author

@swift-ci please test Windows platform

@zoecarver
Copy link
Contributor

@swift-ci please test Windows.

@egorzhdan
Copy link
Contributor Author

@swift-ci please test Windows

@egorzhdan
Copy link
Contributor Author

The CI keeps ignoring me (strangely, only for Windows builds, I can run Linux/macOS builds just fine).
@zoecarver could you please trigger a Windows build once again?

@zoecarver
Copy link
Contributor

@swift-ci please test Windows

@zoecarver
Copy link
Contributor

@egorzhdan that's odd 😕 Sometimes I have to ping the bot a few times. Next time I'd try it two or three times. If it still doesn't work we can ping Mishal to see what's up.

@egorzhdan egorzhdan merged commit 86dadac into swiftlang:main Mar 2, 2021
@egorzhdan egorzhdan deleted the cxx-operators-tests-cleanup branch March 3, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver zoecarver approved these changes

@CyberFlameGO CyberFlameGO CyberFlameGO approved these changes

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egorzhdan @zoecarver @CyberFlameGO