Skip to content

[simplify-cfg] Only check if we can remove releases by performing simple jump threading if our block argument is not a trivial type. #36167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

Eliminates unnecessary work and reduces compile time.

…ple jump threading if our block argument is not a trivial type.

Eliminates unnecessary work and reduces compile time.
@gottesmm gottesmm requested review from meg-gupta and atrick February 25, 2021 20:22
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test OS X platform

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test OS X platform

@atrick
Copy link
Contributor

atrick commented Feb 27, 2021

I'm not sure what the intention is here since tryJumpThreading is still disabled with OSSA. If it's meant to be a short-term placeholder for fully migrating the code then please use TODO: OSSA

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2021

@swift-ci smoke test macOS platform

1 similar comment
@meg-gupta
Copy link
Contributor

@swift-ci smoke test macOS platform

@gottesmm gottesmm merged commit 19dd906 into swiftlang:main Mar 13, 2021
@gottesmm gottesmm deleted the pr-761936430320990a32c8dfb2f85d27f171f186ba branch March 13, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants