[stdlib] Convert existential collection === operator to method #3617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return lhs._underlyingCollectionID == rhs._underlyingCollectionID | ||
| /// Returns `true` iff `self` and `other` use the same `_box` to store their | ||
| /// underlying collections. | ||
| func _isKnownToBeEqual<C: AnyCollectionProtocol>(to other: C) -> Bool |
There was a problem hiding this comment.
Let’s call this _storesSameUnderlyingCollection
|
Just a couple of fixups and this is ready to go. Thanks, Nate! |
natecook1000
force-pushed
the
nc-existenz-identity
branch
from
b2ba0c7 to
34b9b98
Compare
natecook1000
force-pushed
the
nc-existenz-identity
branch
from
122ec33 to
7e6a105
Compare
|
@swift-ci Please test |
|
@swift-ci Please test |
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
|
I cleared the workspaces. If this is good, it should work now. |
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
The
===operator for existential collections is only used for standard library testing. This removes it in favor of an underscored method.Resolved bug number: n/a
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.