Skip to content

[Incremental] Use source file fingerprints *without* top-level type bodies for incremental imports #36188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2021

Conversation

davidungar
Copy link
Contributor

@davidungar davidungar commented Feb 26, 2021

Has been rebased atop main after #36168 merges.

Add InterfaceHashExcludingTypeMembers to BasicSourceFileInfo and use it for module fingerprints in order to make incremental imports work.

Also adds a test.

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test macos platform

@davidungar davidungar force-pushed the module-print-2-rintaro branch 2 times, most recently from 9a25874 to 0adf370 Compare February 26, 2021 22:10
@davidungar davidungar changed the title [DNM: Incremental] Use source file fingerprints *without* top-level type bodies for incremental imports [Incremental] Use source file fingerprints *without* top-level type bodies for incremental imports Feb 26, 2021
@davidungar davidungar force-pushed the module-print-2-rintaro branch from 0adf370 to af32c3d Compare February 26, 2021 22:13
@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

@davidungar davidungar force-pushed the module-print-2-rintaro branch from af32c3d to 0e2165a Compare February 27, 2021 01:17
@davidungar davidungar force-pushed the module-print-2-rintaro branch from 0e2165a to 66b4184 Compare February 27, 2021 01:39
@davidungar davidungar force-pushed the module-print-2-rintaro branch from 66b4184 to d5ef9a0 Compare February 27, 2021 17:24
@davidungar
Copy link
Contributor Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 8184952 into swiftlang:main Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants