-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[ConstraintSystem] Delay inference until let's clear that type variable attempt is successful #36193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test compiler performance |
@swift-ci please test compiler performance |
@swift-ci please test source compatibility debug |
Summary for main fullUnexpected test results, excluded stats for RxCocoa No regressions above thresholds Debug-batchdebug-batch briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
debug-batch detailedRegressed (0)
Improved (1)
Unchanged (delta < 1.0% or delta < 100.0ms) (261)
Releaserelease briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
release detailedRegressed (0)
Improved (1)
Unchanged (delta < 1.0% or delta < 100.0ms) (261)
|
… methods on graph node
This makes sure that solver knows the result of a bind, instead of having to checking `failedConstraint` and allows passing flags.
…le attempt is successful Currently bindings where inferred on every `bindTypeVariable` call, but that's wasteful because not all binds are always correct. To avoid unnecessary inference traffic let's wait until re-activated constraints are simplified and notify binding inference about new fixed type only if all of them are successful.
Just like regular `Bind` constraint `BindOverload` contains no useful information for referenced type variables.
d78b994
to
ca16c37
Compare
@swift-ci please test |
@swift-ci please test source compatibility |
@swift-ci please test source compatibility debug |
Build failed |
@swift-ci please smoke test Windows platform |
1 similar comment
@swift-ci please smoke test Windows platform |
@swift-ci please smoke test macOS platform |
@swift-ci please smoke test Windows platform |
1 similar comment
@swift-ci please smoke test Windows platform |
Two unrelated test failures in macOS:
|
Currently bindings where inferred on every
bindTypeVariable
call,but that's wasteful because not all binds are always correct. To
avoid unnecessary inference traffic let's wait until re-activated
constraints are simplified and notify binding inference about new
fixed type only if all of them are successful.
This is a follow-up to #35903.