Skip to content

[Concurrency] Disable async_taskgroup_throw_recover test on windows #36212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

etcwilde
Copy link
Member

@etcwilde etcwilde commented Mar 1, 2021

This patch XFails this test on windows since it isn't working correctly.
This should unblock things.

@etcwilde etcwilde requested a review from ktoso March 1, 2021 16:55
@etcwilde
Copy link
Member Author

etcwilde commented Mar 1, 2021

@swift-ci please smoke test

@etcwilde
Copy link
Member Author

etcwilde commented Mar 1, 2021

@swift-ci please smoke test windows

This patch disables this test on windows since it isn't working
correctly.
@etcwilde etcwilde force-pushed the ewilde/unblock-windows-with-async branch from e3234a8 to cdc460b Compare March 1, 2021 18:51
@etcwilde
Copy link
Member Author

etcwilde commented Mar 1, 2021

@swift-ci please smoke test

@etcwilde etcwilde changed the title [Concurrency] XFAIL async_taskgroup_throw_recover on windows [Concurrency] Disable async_taskgroup_throw_recover test on windows Mar 1, 2021
@etcwilde
Copy link
Member Author

etcwilde commented Mar 1, 2021

@swift-ci please smoke test macOS

@etcwilde
Copy link
Member Author

etcwilde commented Mar 1, 2021

@swift-ci please smoke test Windows

@etcwilde
Copy link
Member Author

etcwilde commented Mar 2, 2021

@swift-ci please smoke test windows

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks...

I really wonder if this isn't general runtime issues on windows -- the implementation of groups itself really should not manifest anything platform specific 🤔

@ktoso
Copy link
Contributor

ktoso commented Mar 2, 2021

Windows failure was #36221 which we'll disable on Windows for now until fixed as well

@ktoso ktoso merged commit b655a4a into swiftlang:main Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants