-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[ConstraintGraph] Optimize edge contraction #36220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously on every step solver would iterate over all constraints in attempt to find `BindParam` which could be contracted. Instead of doing that, let's take advantage of the fact that all (participating) closures are recorded in the constraint system during constraint generation, so it should be possible to check either outer parameter types are contractable with their inner uses.
…nce it's only used by `contractEdges`
@swift-ci please smoke test compiler performance |
@swift-ci please test compiler performance |
hborla
approved these changes
Mar 2, 2021
Summary for main fullUnexpected test results, excluded stats for RxCocoa No regressions above thresholds Debug-batchdebug-batch briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
debug-batch detailedRegressed (0)
Improved (3)
Unchanged (delta < 1.0% or delta < 100.0ms) (259)
Releaserelease briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
release detailedRegressed (0)
Improved (1)
Unchanged (delta < 1.0% or delta < 100.0ms) (261)
|
There are no closures in this test-case and counter is only increased when there are closures to check.
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on every step solver would iterate over all
constraints in attempt to find
BindParam
which couldbe contracted. Instead of doing that, let's take advantage
of the fact that all (participating) closures are recorded
in the constraint system during constraint generation, so
it should be possible to check either outer parameter types
are contractable with their inner uses.
In combination with incremental bindings new
contactEdges
is effectively free.