Funnel all "get local conformances" queries through a request. #36223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LookupAllConformancesInContextRequest caches the results of performing lookup of all of the conformances ascribed to a given iterable declaration context. However, it was only used in a small number of places, with most clients using a different API (`getLocalConformances()`) that does not provide caching, cycle detection, or dependency tracking. Sink LookupAllConformancesInContextRequest lower in the stack, and reimplement `getLocalConformances()` on top of it. This ensures that all of the various queries go through the cached request and get the benefits of the request-evaluator infrastructure.
…formances() The uncached, rarely-used getLocalProtocols() does not benefit from having its own distinct implementation. Reimplement it on top of getLocalConformances() to simplify things and benefit from the request-evaluator infrastructure.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
slavapestov
reviewed
Mar 2, 2021
|
|
||
| // Copy all of the conformances we want. | ||
| SmallVector<ProtocolConformance *, 2> result; | ||
| std::copy_if( |
There was a problem hiding this comment.
You could bypass the copy_if() if the lookupKind is All, which is the default here.
There was a problem hiding this comment.
I have a silly SmallVector-vs-vector difference to deal with as well, but yes, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LookupAllConformancesInContextRequestcaches the results of performinglookup of all of the conformances ascribed to a given iterable
declaration context. However, it was only used in a small number of
places, with most clients using a different API
(
getLocalConformances()) that does not providecaching, cycle detection, or dependency tracking.
Sink
LookupAllConformancesInContextRequestlower in the stack, andreimplement
getLocalConformances()on top of it. This ensures thatall of the various queries go through the cached request and get the
benefits of the request-evaluator infrastructure.