[TaskGroup] Towards ABI stability of groups #36228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Mar 2, 2021
| @@ -46,6 +46,9 @@ enum { | |||
| /// The number of words (in addition to the heap-object header) | |||
| /// in a default actor. | |||
| NumWords_DefaultActor = 10, | |||
|
|
|||
| /// The number of words in a task group. | |||
| NumWords_TaskGroup = 32, | |||
There was a problem hiding this comment.
I'll slim it down a bit, we still have the mutex in there meh
ktoso
force-pushed
the
wip-groups-towards-clean-abi
branch
from
7a63fe4 to
aedbbe6
Compare
|
@swift-ci please smoke test |
ktoso
commented
Mar 2, 2021
| }; | ||
| /// Upon a future task's completion, offer it to the task group it belongs to. | ||
| void offer(AsyncTask *completed, AsyncContext *context, ExecutorRef executor); | ||
| }; |
There was a problem hiding this comment.
so the TaskGroup only contains the actual ABI now 👍
There was a problem hiding this comment.
(more functions to come here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the C++ TaskGroup into an opaque container, the same way as DefaultActor does.
We then have all implementation inside
TaskGroupImpl.I will define all remaining ABI on TaskGroup tomorrow or tonight, but thanks for this is is all nice and clean.