[libSyntax] Reference count SyntaxData #36230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
pr/ref-count-syntaxdata
branch
from
1873d23 to
8ed3ea4
Compare
|
@swift-ci Please test Linux |
ahoppen
force-pushed
the
pr/ref-count-syntaxdata
branch
from
8ed3ea4 to
88e9048
Compare
|
Full testing passed before rebasing onto @swift-ci Please smoke test |
|
@swift-ci Please test Windows |
Instead of having a heap-allocated RefCountedBox to store a SyntaxData's parent, reference-count SyntaxData itself. This has a couple of advantages: - When passing SyntaxData around, only a pointer needs to be passed instead of the entire struct contents. This is faster. - We can later introduce a SyntaxDataRef, which behaves similar to SyntaxData, but delegates the responsibility that the parent stays alive to the user. While sacrificing guaranteed memory safety, this means that SyntaxData can then be stack-allocated without any ref-counting overhead.
ahoppen
force-pushed
the
pr/ref-count-syntaxdata
branch
from
88e9048 to
56a9234
Compare
|
And another rebase onto @swift-ci Please smoke test |
|
@swift-ci Please test |
|
Build failed |
rintaro
approved these changes
Mar 4, 2021
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a heap-allocated
RefCountedBoxto store aSyntaxData's parent, reference-countSyntaxDataitself. This has a couple of advantages:SyntaxDataaround, only a pointer needs to be passed instead of the entire struct contents. This is faster.SyntaxDataRef, which behaves similar toSyntaxData, but delegates the responsibility that the parent stays alive to the user. While sacrificing memory safety, this means thatSyntaxDatacan then be stack-allocated without any ref-counting overhead.