[Concurrency] Run async main code on main thread #36239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
I'm going to add a check in the |
etcwilde
force-pushed
the
ewilde/run-async-main-on-main-thread
branch
from
86d5eed to
4576825
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
DougGregor
approved these changes
Mar 2, 2021
|
@swift-ci please smoke test windows |
This patch moves the actual running of the main code onto the main thread by making it part of the main actor. This should be more consistent with what folks are expecting.
This patch adds a check to verify that we're running on the main thread when running the async-main function.
etcwilde
force-pushed
the
ewilde/run-async-main-on-main-thread
branch
from
4576825 to
12c3eb2
Compare
|
@swift-ci please smoke test |
etcwilde
commented
Mar 3, 2021
| @@ -77,6 +79,11 @@ actor A { | |||
| @main struct RunIt { | |||
| static func main() async { | |||
| print("starting") | |||
| if checkIfMainQueue(expectedAnswer: true) { | |||
There was a problem hiding this comment.
If we don't force Windows to be running on the main thread, then this will probably fail on Windows, or at least not be all that reliable. :(
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the actual running of the main code onto the main
thread by making it part of the main actor. This should be more
consistent with what folks are expecting.
Resolves: rdar://73255194