[libSyntax] Store range in token_data in C lib parse actions #36249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/range-in-token-data
branch
from
743f0cc to
bb6381d
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
We don't actually need the range for layout nodes, so just store it for token nodes. This will also make deferred node handling easier later on, because we don't need to keep track of layout node ranges.
…r return a layout node's range
ahoppen
force-pushed
the
pr/range-in-token-data
branch
from
bb6381d to
1e64023
Compare
|
@swift-ci Please smoke test and merge |
rintaro
approved these changes
Mar 8, 2021
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually need the range for layout nodes, so just store it for token nodes. This will also make deferred node handling easier later on, because we don't need to keep track of layout node ranges.
The client of the C lib parse actions can still compute the total byte length of the node by adding the byte lengths of its children.
The corresponding changes to the C client in SwiftSyntax are being made in swiftlang/swift-syntax#260.