Temporarily Disable Cross-Module Builds in Legacy Tests #36260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests rely on YAML files and the driver's old behavior of reading those YAML files to affect their outputs. The new driver is moving to a mode where cross-module incremental builds will also enable the reading of priors from a serialized module dependency graph. Therefore, these tests will not behave the same, as in many cases we are not even reading the swiftdeps files they depend upon!
|
@swift-ci smoke test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests rely on YAML files and the driver's old behavior of reading
those YAML files to affect their outputs. The new driver is moving to
a mode where cross-module incremental builds will also enable the
reading of priors from a serialized module dependency graph. Therefore,
these tests will not behave the same, as in many cases we are not even
reading the swiftdeps files they depend upon!