Enforce safe access to unsafe global actor declarations only from "new" code #36266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With "unsafe" global actor isolation, we only enforce actor isolation when interacting with other explicitly-isolated code. This allows some code to be annotated with, e.g., `@MainActor(unsafe)` so that users who opt into concurrency get proper diagnostics, but existing code does not change.
Whether it's a cross-actor reference is better modeled as a separate axis rather than part of the "kind". All of the clients were treating it this was already.
…w" code. Allow references to unsafe global actor-isolated declarations only from existing code that has not adopted concurrency features (such as async, @Concurrent closures, etc.). This allows declarations that should be isolated to a global actor to be annotated as such without breaking existing code (as if isolation was unspecified), while code that does adopt concurrency will treat the declaration as being part of that global actor.
DougGregor
changed the title
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
Linux failure was unrelated. Trying again... |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow references to unsafe global actor-isolated declarations only from
existing code that has not adopted concurrency features (such as
async, @Concurrent closures, etc.). This allows declarations that
should be isolated to a global actor to be annotated as such without
breaking existing code (as if isolation was unspecified), while code
that does adopt concurrency will treat the declaration as being part
of that global actor.
rdar://74241687