[Frontend/Test] Fix flaky lock_interface test #36285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing that the compiler rebuilds the same module more than once with -disable-interface-lock was not reliable as some jobs could be executed after the module was rebuilt. Just make sure the compiler accepts the flag :/
|
@swift-ci Please smoke test |
|
@swift-ci Please test Ubuntu 20.04 platform |
|
@swift-ci Please test CentOS 8 platform |
CodaFi
approved these changes
Mar 4, 2021
xymus
changed the title
|
Build failed |
|
The Ubuntu failure is unrelated, the test succeeded on both GNU/Linux platforms. |
|
|
|
It's trying to build many dependencies of Foo in parallel to make the implicit module build system try to rebuild Foo's module interface more than once. When the lock files are used it triggers a single rebuild, but without the lock files each of the frontend job can trigger its own rebuild. I believe the |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing that the compiler rebuilds the same module more than once with
-disable-interface-lockwas not reliable as some jobs could be executed after the module was rebuilt. Just make sure the compiler accepts the flag.Also reorder permission change and FileCheck calls to make failures less likely to leave the tmp folder in an unwritable state.
This test was reenabled in #36185.