-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[ConstraintSystem] Use correct locator when filtering disjunction cho… #36300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ices `simplifyAppliedOverloads(Constraint *, ...)` wouldn't filter choices based on labels unless it finds recorded labels in the constraint system based on the provided locator. `addOverloadSet` used incorrect locator when calling `simplifyAppliedOverloads` which means that this call was effectively a no-op.
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@swift-ci please smoke test compiler performance |
@swift-ci please test compiler performance |
@swift-ci please smoke test Windows platform |
Smoke test performance is super flaky lately, I guess I should just stop running it for a while :/ |
e.g. #35966 - empty PR but still some of the stats still jump up and down more than 1%, interestingly |
@swift-ci please smoke test compiler performance |
1 similar comment
@swift-ci please smoke test compiler performance |
Summary for main fullUnexpected test results, excluded stats for RxCocoa No regressions above thresholds Debug-batchdebug-batch briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
debug-batch detailedRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (263)
Releaserelease briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
release detailedRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (263)
|
Summary for main smoketestRegressions found (see below) Debugdebug briefRegressed (1)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
debug detailedRegressed (3)
Improved (2)
Unchanged (delta < 1.0% or delta < 100.0ms) (258)
Releaserelease briefRegressed (1)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
release detailedRegressed (2)
Improved (1)
Unchanged (delta < 1.0% or delta < 100.0ms) (260)
|
Git bisect has identified this change as the source of a regression on my Fedora 33 (x86-64) box. Is this expected?
|
I did some triage. The branch (unmerged) tests clean, so that means that the testing results are stale. I bisected the conflict further and found that this pull request conflicts with #36267 (also authored by you). This conflict is blocking testing of unrelated PRs, so I'm going to revert this one (arbitrarily). |
…tion choices" This reverts commit 2df4ba7 from swiftlang#36300 which conflicts with swiftlang#36267 and was missed because of classic "time of test was too old before merging".
…ices
simplifyAppliedOverloads(Constraint *, ...)
wouldn't filter choicesbased on labels unless it finds recorded labels in the constraint system
based on the provided locator.
addOverloadSet
used incorrect locatorwhen calling
simplifyAppliedOverloads
which means that this call waseffectively a no-op.