Skip to content

IRGen: Enable update of extended frame pointer entry on x86_64 #36312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aschwaighofer
Copy link
Contributor

So far this was only enabled on arm64. Let's see whether the x86_64 backend can handle it.

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 5, 2021

Build failed
Swift Test Linux Platform
Git Sha - ba901ad

@swift-ci
Copy link
Contributor

swift-ci commented Mar 5, 2021

Build failed
Swift Test OS X Platform
Git Sha - ba901ad

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 6, 2021

Build failed
Swift Test Linux Platform
Git Sha - ba901ad

@swift-ci
Copy link
Contributor

swift-ci commented Mar 6, 2021

Build failed
Swift Test OS X Platform
Git Sha - ba901ad

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 8, 2021

Build failed
Swift Test OS X Platform
Git Sha - ba901ad

@aschwaighofer
Copy link
Contributor Author

Assertion failed: (CurrentState.load(std::memory_order_relaxed).Flags.getStatus() == Status::Idle && "actor not idle during destruction?"), function destroy, file /Users/buildnode/jenkins/workspace/swift-PR-macos/branch-main/swift/stdlib/public/Concurrency/Actor.cpp, line 430.

On i386, looks unrelated. This patch should only change IRGen on x86_64.

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test os x platform

@kastiglione
Copy link
Contributor

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test windows

2 similar comments
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test windows

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test windows

@fredriss
Copy link
Contributor

@aschwaighofer we need this landed ASAP and in the next submission.

@aschwaighofer aschwaighofer merged commit 07823ab into swiftlang:main Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants