Add 'bitPattern:' label to '(U)Int.init(ObjectIdentifier)' #3634
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
aschwaighofer
force-pushed
the
int_init_objectidentifier_label
branch
from
20d7e29 to
46a81cd
Compare
|
@swift-ci Please smoke test linux |
aschwaighofer
added
the
swift evolution pending discussion
| @@ -631,3 +631,17 @@ extension ObjectIdentifier { | |||
| Builtin.unreachable() | |||
| } | |||
| } | |||
|
|
|||
| extension UInt { | |||
| @available(*, unavailable, message: "use the 'UInt(bitPattern:)' initializer") | |||
There was a problem hiding this comment.
Can we use renamed="init(bitPattern:)" so that users will get a fixit?
|
Just two small suggestions, but LGTM otherwise! Thank you! |
| public init(_ objectID: ObjectIdentifier) { | ||
| Builtin.unreachable() | ||
| } | ||
| } | ||
|
|
||
| extension Int { | ||
| @available(*, unavailable, message: "use the 'Int(bitPattern:)' initializer") | ||
| @available(*, unavailable, message: "init(bitPattern:)") | ||
| public init(_ objectID: ObjectIdentifier) { |
There was a problem hiding this comment.
This would be 'renamed' not 'message' will fix.
SR-2064 rdar://27327186
aschwaighofer
force-pushed
the
int_init_objectidentifier_label
branch
from
42725f7 to
b6da135
Compare
aschwaighofer
added
swift evolution approved
|
@swift-ci Please test and merge |
|
Failure looks spurious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'bitPattern:' label to '(U)Int.init(ObjectIdentifier)'
This the patch for swift-evolution proposal 0124.
SR-2064
rdar://27327186