Skip to content

Revert 1e3de357: XFAIL TSAN Tests on AS Hosts #36372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2021
Merged

Revert 1e3de357: XFAIL TSAN Tests on AS Hosts #36372

merged 1 commit into from
Mar 15, 2021

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek kubamracek requested review from delcypher and CodaFi March 9, 2021 20:21
@CodaFi
Copy link
Contributor

CodaFi commented Mar 9, 2021

@swift-ci please test Apple Silicon macOS platform

@CodaFi
Copy link
Contributor

CodaFi commented Mar 9, 2021

Looks like the issue persisted

/Users/buildnode/jenkins/workspace/swift-PR-macos-apple-silicon/branch-main/swift/test/Sanitizers/tsan.swift:75:11: error: CHECK: expected string not found in input
14:44:21 // CHECK: ThreadSanitizer: data race
14:44:21           ^
14:44:21 <stdin>:1:1: note: scanning from here
14:44:21 ThreadSanitizer: unsupported vm address limit 0x800000000000, expected 0x000fc0000000.
14:44:21 ^
14:44:21 
14:44:21 Input file: <stdin>
14:44:21 Check file: /Users/buildnode/jenkins/workspace/swift-PR-macos-apple-silicon/branch-main/swift/test/Sanitizers/tsan.swift
14:44:21 
14:44:21 -dump-input=help explains the following input dump.
14:44:21 
14:44:21 Input was:
14:44:21 <<<<<<
14:44:21           1: ThreadSanitizer: unsupported vm address limit 0x800000000000, expected 0x000fc0000000.
14:44:21 check:75     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
14:44:21 >>>>>>
14:44:21

@kubamracek
Copy link
Contributor Author

I think that's expected — I did not merge the fix into 20210107, swiftlang/llvm-project#2637.

@kubamracek
Copy link
Contributor Author

@swift-ci please test Apple Silicon macOS platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1668cfb

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1668cfb

@kubamracek
Copy link
Contributor Author

@swift-ci test

@jckarter
Copy link
Contributor

Force-merging this because these tests are UPASS-ing on the CI bots and the failures in PR testing are unrelated.

@jckarter jckarter merged commit ddb96cd into main Mar 15, 2021
@jckarter jckarter deleted the revert-1e3de357 branch March 15, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi CodaFi approved these changes

@delcypher delcypher Awaiting requested review from delcypher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubamracek @CodaFi @swift-ci @jckarter