Add test for relaxed circularity check from parse-time lookup removal #36373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't work in 5.3:
The old parse-time circularity check would kick in if nothing else in an outer local scope had the same name as the binding currently being initialized. However, type and global members were not in scope to parse-time name lookup, so the error would kick in even if the code would otherwise have a valid interpretation. Of course with #34137, this is all gone and we diagnose all cycles later, where we have more semantic information.