Improve request evaluator cycle diagnostics #36375
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
force-pushed
the
the-cycle-begins-anew
branch
from
9771a7c to
1ef5414
Compare
|
@swift-ci please smoke test |
beccadax
commented
Mar 10, 2021
test/CircularReferences/Inputs/custom-modules/CircularLibrary.swift
Outdated
Show resolved
Hide resolved
|
Nice! |
beccadax
force-pushed
the
the-cycle-begins-anew
branch
from
637e534 to
0e13dba
Compare
beccadax
changed the title
|
@swift-ci please test |
|
The previous test case was very fragile and is, in itself, a bug we probably ought to fix. I've filed that bug as SR-14324 and added a command-line argument to the frontend which artificially creates a request cycle involving arbitrary types that we can diagnose. |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
Build failed |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
This commit makes the pretty-printing behavior of `DiagnosticEngine` easily accessible via a new `Decl::getLocByPrintingIfNeeded()` call and uses that call in various places related to `extractNearestSourceLoc()`, ultimately improving diagnostics for cycles involving serialized declarations. Note that the test case added here should probably not cause a circularity error; SR-14324 tracks this bug.
This commit implements a facility to artificially cause a request cycle involving various types so we can test how circularity errors print without having to carefully craft test cases where they happen.
beccadax
force-pushed
the
the-cycle-begins-anew
branch
from
0e13dba to
b96a107
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
DiagnosticEngine's declaration-pretty-printing facility to allow it to be used fromextractNearestSourceLoc(), improving cycle diagnostics that were previously emitted at<invalid>:0.-debug-cyclesoutput to indicate which request in the dumped stack was repeated.I haven't figured out how to test these changes yet, which is why this is still currently a WIP.