[libSyntax] Add leading and trailing space property for Token #36383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/add-leading-trailing-space-for-token
branch
from
b8ef673 to
86652af
Compare
ahoppen
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
The overall design of requires_leading_space and requires_trailing_space looks good to me.
As to the classifications, which tokens need spaces, all you choices look reasonable to me and I don’t have any objections but I believe we’ll need to come back here and re-classify once we get a feeling how the SyntaxBuildable actually produces code – but we can do that in follow-up PRs.
Checking it locally, I noticed that Python lint fails. Could you make sure that utils/python_lint.py passes?
Just invoke it as follows
cd /path/to/swift
utils/python_lint.py
kimdv
force-pushed
the
kimdv/add-leading-trailing-space-for-token
branch
from
86652af to
ad93067
Compare
|
It should pass now @ahoppen 🎉 |
ahoppen
approved these changes
Mar 11, 2021
kimdv
force-pushed
the
kimdv/add-leading-trailing-space-for-token
branch
from
ad93067 to
df86242
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a leading/trailing space property on
Token.pyso we can usegybfor generate in swiftlang/swift-syntax#264