Create integerparsing init for substring #36413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a substring, _parseASCIISlowPath is being executed. Higher performance can be expected just by wrapping it with a String once.
|
@swift-ci Please smoke test |
xwu
reviewed
Mar 14, 2021
| @@ -197,4 +197,31 @@ extension FixedWidthInteger { | |||
| public init?(_ description: String) { | |||
| self.init(description, radix: 10) | |||
| } | |||
|
|
|||
| /// Creates a new integer value from the given Substring. | |||
There was a problem hiding this comment.
Suggested change
| /// Creates a new integer value from the given Substring. | |
| /// Creates a new integer value from the given `Substring`. |
|
|
||
| /// Creates a new integer value from the given Substring. | ||
| /// | ||
| /// Substring can be parsed at a high speed just by substituting strings. |
There was a problem hiding this comment.
Suggested change
| /// Substring can be parsed at a high speed just by substituting strings. |
This is not relevant to the user-facing documentation.
| /// | ||
| /// Substring can be parsed at a high speed just by substituting strings. | ||
| /// | ||
| /// The Substring passed as `description` may begin with a plus or minus sign |
There was a problem hiding this comment.
Suggested change
| /// The Substring passed as `description` may begin with a plus or minus sign | |
| /// The `Substring` passed as `description` may begin with a plus or minus sign |
| /// Int("10000000000000000000000000") // Out of range | ||
| /// | ||
| /// - Parameter description: The ASCII representation of a number. | ||
| @inlinable |
There was a problem hiding this comment.
This needs availability annotations for the standard library, and probably @_alwaysEmitIntoClient for ABI reasons. I forget exactly, but I think that implies @inlinable.
|
Hi @JeaSungLEE, I’ve reworked integer parsing in #36623 so that this should not be necessary; that PR will likely be merged soon—do you want to see if that fixes your issue without adding a new initializer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a substring, _parseASCIISlowPath is being executed. Higher performance can be expected just by wrapping it with a String once.
Note
Current speed difference
Int(substring):: Time: 0.024948954582214355
Int(String(substring)):: Time: 7.700920104980469e-05