[libSyntax] Store data of RecoredeOrDeferredNode as PointerIntPair #36420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This furthere reduces the size of ParsedRawSyntaxNode, as well as for intermediate data structures using in SyntaxParseActions, improving syntax parsing performance.
rintaro
approved these changes
Mar 12, 2021
Comment on lines
+59
to
+61
| /// \c llvm::PointerIntPair. This is in particular guaranteed for pointers | ||
| /// to C/C++ objects and for pointers that were generated by Swift and passed | ||
| /// to the compiler via a C API (in particular \c CLibParseActions ). |
There was a problem hiding this comment.
This is probably true, but just in case could you add an assertion in the RecordedOrDeferredNode constructor?
/// All clients should use assertions to do a run-time check to ensure that
/// this is actually true.
There was a problem hiding this comment.
PointerIntPairInfo already does this check. I suppose that it is considered the client of PointerLikeTypeTraits and we are just using PointerIntPairInfo.
https://github.com/apple/llvm-project/blob/apple/main/llvm/include/llvm/ADT/PointerIntPair.h#L178
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further reduces the size of
ParsedRawSyntaxNode, as well as for intermediate data structures using inSyntaxParseActions, slightly improving syntax parsing performance.