[ConstraintSystem] Re-activate constraints if, due to incorrect reference, member type has been bound before base type #36427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…longs to key path component result
…arify its meaning New name is `isInKeyPathComponent` since it's implemeneted as a check for presence of `KeyPathComponent` element in the locator that covers every sub-element contained in a key path component as well.
…ence, member type has been bound before base type If member has been bound before the base and the base was incorrect at that (e.g. fallback to default `Any` type), then we need to re-activate all of the constraints associated with this member reference otherwise some of the constraints could be left unchecked in inactive state. This is especially important for key path expressions because `key path` constraint can't be retired until all components are simplified. Resolves: SR-13364 Resolves: rdar://66706980 Resolves: rdar://74711236
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test Linux platform |
hborla
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If member has been bound before the base and the base was
incorrect at that (e.g. fallback to default
Anytype),then we need to re-activate all of the constraints
associated with this member reference otherwise some of
the constraints could be left unchecked in inactive state.
This is especially important for key path expressions because
key pathconstraint can't be retired until all componentsare simplified.
Resolves: SR-13364
Resolves: rdar://66706980
Resolves: rdar://74711236