Skip to content

[stdlib] Speed up the FixedPointConversion tests #36434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

benrimmington
Copy link
Contributor

@benrimmington benrimmington commented Mar 13, 2021

Follow-up to: #36205

  • Added python3 compatibility.
  • Added .forEach parameterized code.
  • Removed long_test requirements.
  • Tested on macOS and watchOS simulator.
utils/run-test \
  --build-dir ../build/Ninja-RelWithDebInfoAssert \
  --subset all \
  --target macosx-x86_64 \
  --verbose \
  validation-test/stdlib/FixedPointConversion/*.swift

********************

Testing Time: 16.77s (old), 13.82s (new)
  Unsupported: 20
  Passed     : 20
utils/run-test \
  --build-dir ../build/Ninja-RelWithDebInfoAssert \
  --subset all \
  --target watchsimulator-i386 \
  --verbose \
  validation-test/stdlib/FixedPointConversion/*.swift

********************

Testing Time: 60.25s (old), 14.37s (new)
  Unsupported: 20
  Passed     : 20

@benrimmington
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ac5ae7e361b4657931ab6088f0b5df972ce827c8

@benrimmington
Copy link
Contributor Author

<unknown>:0: error: module file '/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-main/buildbot_linux/foundation-linux-x86_64/module-cache/32AAGSXEGLMNI/SwiftShims-RRC23Z1R7B4K.pcm' is out of date and needs to be rebuilt: signature mismatch
<unknown>:0: note: imported by module 'SwiftOverlayShims' in '/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-main/buildbot_linux/foundation-linux-x86_64/module-cache/32AAGSXEGLMNI/SwiftOverlayShims-RRC23Z1R7B4K.pcm'
/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-main/swift-corelibs-foundation/Sources/Foundation/Data.swift:25:8: error: missing required module 'SwiftOverlayShims'
import Glibc
       ^
ninja: build stopped: subcommand failed.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ac5ae7e361b4657931ab6088f0b5df972ce827c8

@benrimmington
Copy link
Contributor Author

Unexpectedly Passed Tests (1):
  lldb-shell :: Stepper/TestSwiftBenchmarkOnone.1.test

@benrimmington
Copy link
Contributor Author

@swift-ci Please test

@benrimmington
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a315221

@benrimmington
Copy link
Contributor Author

Failed Tests (1):
  Swift(linux-x86_64) :: Driver/static-stdlib-linux.swift

@benrimmington
Copy link
Contributor Author

@swift-ci Please test Linux platform

@benrimmington benrimmington marked this pull request as ready for review March 15, 2021 09:52
@stephentyrone stephentyrone merged commit aac2caf into swiftlang:main Mar 15, 2021
@benrimmington benrimmington deleted the speed-up-tests branch March 16, 2021 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants