[Diagnostics] Check whether missing conformance could be fixed by using .rawValue
#36445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng `.rawValue` A lot of operators (and most likely regular functions a well) have overloads that accept i.e. a generic parameter that conforms to `StringProtocol`, so the best fix in situations when argument is a raw representable type would be to check whether `.rawValue` conforms to the expected protocol and use it if so. Resolves rdar://problem/75367157
In situations like `""?` or `42?`, let's not record an unwrap fix since it was incorrect to use `?` in the first place.
…ble type doesn't conform but `.rawValue` does
|
@swift-ci please smoke test |
hborla
reviewed
Mar 16, 2021
…Value` still diagnose it as conformance issue Conformance requirement failure is a more descriptive error, augment it with a note about missing `.rawValue`.
|
@swift-ci please smoke test |
hborla
approved these changes
Mar 17, 2021
|
@swift-ci please test Windows platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please smoke test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of operators (and most likely regular functions a well) have
overloads that accept i.e. a generic parameter that conforms to
StringProtocol, so the best fix in situations when argument isa raw representable type would be to check whether
.rawValueconforms to the expected protocol and use it if so.
Resolves rdar://problem/75367157