[ConstraintSystem] Teach getFunctionArgApplyInfo about inout expr…
#36459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essions Currently `getFunctionArgApplyInfo` expects a locator with `ApplyArgToParam` element to identify location of the argument. `InOutExpr` could only be used in argument positions but it doesn't have the same locator format as non-inout arguments, so `getFunctionArgApplyInfo` needs to do some digging in the AST to retrieve that information. Resolves: rdar://75146811
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test Windows platform |
1 similar comment
|
@swift-ci please smoke test Windows platform |
hborla
approved these changes
Mar 17, 2021
|
@swift-ci please smoke test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…essions
Currently
getFunctionArgApplyInfoexpects a locator withApplyArgToParamelement to identify location of the argument.
InOutExprcould only be usedin argument positions but it doesn't have the same locator format as non-inout
arguments, so
getFunctionArgApplyInfoneeds to do some digging in the ASTto retrieve that information.
Resolves: rdar://75146811