GSB: Narrow scope of conditional requirement inference #36460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
If we have a conformance requirement T : P, and a concrete type requirement T == G<...>, and G _conditionally_ conforms to P, we would infer the conditional requirements of G needed to satisfy the conformance. However, if the conformance requirement T : P was not explicit, this would mean in practice that we would need to infer an infinite number of conditional requirements, because there might be an infinite number of types T for which T : P. Previously we would infer these up to some limit, based on how many levels of nested types the GSB had expanded. Since this is untenable, let's instead change the rules so that conditional requirement inference is only performed when the concretizing requirement was explicit.
slavapestov
force-pushed
the
non-well-founded-conditional-requirement-inference
branch
from
dc16a2e to
8e4598e
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test macOS |
1 similar comment
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a conformance requirement T : P, and a concrete type
requirement T == G<...>, and G conditionally conforms to P,
we would infer the conditional requirements of G needed to
satisfy the conformance.
However, if the conformance requirement T : P was not explicit,
this would mean in practice that we would need to infer an
infinite number of conditional requirements, because there
might be an infinite number of types T for which T : P.
Previously we would infer these up to some limit, based on
how many levels of nested types the GSB had expanded.
Since this is untenable, let's instead change the rules so
that conditional requirement inference is only performed
when the concretizing requirement was explicit.