Skip to content

[Index] Add the dynamic role for calls to class methods #36484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

bnbarham
Copy link
Contributor

class functions can be overridden in subclasses but did not have the
Dynamic role added to their calls. Also add the ReceivedBy relation
in the simple case of an open archetype, leaving the more complicated
general generic case for now.

@bnbarham bnbarham requested review from akyrtzi and nathawes March 18, 2021 05:37
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 695fd772bee4d048bb353de9dfdf7bc4ad662f68

@akyrtzi akyrtzi requested a review from benlangmuir March 18, 2021 20:58
@bnbarham
Copy link
Contributor Author

@swift-ci please test Linux platform

@bnbarham bnbarham force-pushed the dynamic-class-methods branch from 695fd77 to 872bb09 Compare March 18, 2021 22:02
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 872bb094e751e4bb7842418d12357a509370f4a2

`class` functions can be overridden in subclasses but did not have the
`Dynamic` role added to their calls. Also add the `ReceivedBy` relation
in the simple case of an open archetype, leaving the more complicated
general generic case for now.
@bnbarham bnbarham force-pushed the dynamic-class-methods branch from 872bb09 to 39bb0d0 Compare March 18, 2021 23:11
@bnbarham
Copy link
Contributor Author

Didn't remove the Override relation from the test after removing classMethod from the protocol.

@swift-ci please test

@bnbarham bnbarham merged commit be10554 into swiftlang:main Mar 19, 2021
@bnbarham bnbarham deleted the dynamic-class-methods branch March 19, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants