SIL: Gate checkForLeaksAfterDestruction to asserts builds #36502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
fredriss
approved these changes
Mar 25, 2021
kastiglione
deleted the
SIL-Gate-checkForLeaksAfterDestruction-to-asserts-builds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few lldb bug reports have shown that
SILModule::checkForLeaksAfterDestruction()can fail. The root cause is TBD, possibly by callingIRGenRequest::evaluateconcurrently (the leaks check uses counters that are not thread safe).This leaks check should reasonably be performed only in asserts builds. That way end users won't face a crash if there's a race in how the check is performed, or if there is a leak. Note that
SILModule::checkForLeaks()is called only in asserts builds.rdar://70826934
(cherry picked from #35568)