Skip to content

Ask Cocoa for terminated string contents #36507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Catfish-Man
Copy link
Contributor

@Catfish-Man Catfish-Man commented Mar 19, 2021

Fixes rdar://74006308

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Regression OLD NEW DELTA RATIO
ObjectiveCBridgeASCIIStringFromFile 0 6 +600000.0% 0.00x
 
Improvement OLD NEW DELTA RATIO
FlattenListFlatMap 7077 6549 -7.5% 1.08x (?)

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
ObjectiveCBridgeASCIIStringFromFile 0 6 +600000.0% 0.00x
FlattenListFlatMap 3863 6600 +70.9% 0.59x (?)
FlattenListLoop 1632 2504 +53.4% 0.65x (?)
NSStringConversion.UTF8 985 1124 +14.1% 0.88x (?)

Code size: -Osize

Performance: -Onone

Regression OLD NEW DELTA RATIO
ObjectiveCBridgeASCIIStringFromFile 0 14 +1400000.0% 0.00x

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@Catfish-Man Catfish-Man requested a review from milseman March 19, 2021 19:16
@Catfish-Man Catfish-Man self-assigned this Mar 19, 2021
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just not sure why that include is there.

@Catfish-Man Catfish-Man force-pushed the theres-a-hole-at-the-end-where-the-bits-fall-out branch from a68820e to a220e52 Compare March 19, 2021 20:00
(cherry picked from commit b7ce22ba1525dccd47f4095a9bf8a640b238a5fa)
@Catfish-Man Catfish-Man force-pushed the theres-a-hole-at-the-end-where-the-bits-fall-out branch from a220e52 to e793e0e Compare March 19, 2021 20:01
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit 2f6fb2d into swiftlang:main Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants