Skip to content

SILVerifier: fix a wrong debug-scope verifier crash #36550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2021
Merged

SILVerifier: fix a wrong debug-scope verifier crash #36550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions lib/SIL/Verifier/SILVerifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5465,13 +5465,6 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
return;

const SILDebugScope *LastSeenScope = nullptr;
for (SILInstruction &SI : *BB) {
if (SI.isMetaInstruction())
continue;
LastSeenScope = SI.getDebugScope();
AlreadySeenScopes.insert(LastSeenScope);
break;
}
for (SILInstruction &SI : *BB) {
if (SI.isMetaInstruction())
continue;
Expand Down
10 changes: 10 additions & 0 deletions test/DebugInfo/guard-let-scope.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,13 @@ func f(c: AnyObject?) {
}
print(x)
}

// Check that we don't crash with a verifier error on this.
protocol P {}

public func testit(_ x: AnyObject) -> Bool {
guard let _ = x as? P else {
return false
}
fatalError()
}