Skip to content

[concurrency] Expunge 'actor class' from diagnostics #36557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etcwilde
Copy link
Member

@etcwilde etcwilde commented Mar 23, 2021

This patch goes through and removes references to actor class from the comments and diagnostics, replacing them simply with actor or actors. This way we aren't confusing folks by calling them classes.

Resolves: rdar://74151370

@etcwilde etcwilde requested review from kavon and DougGregor March 23, 2021 22:09
@etcwilde
Copy link
Member Author

@swift-ci please smoke test

@etcwilde
Copy link
Member Author

@swift-ci please smoke test macOS

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@etcwilde
Copy link
Member Author

@swift-ci please smoke test macOS

@etcwilde etcwilde merged commit 3f97abf into swiftlang:main Mar 24, 2021
@etcwilde etcwilde deleted the ewilde/expunge-actor-class-diagnostics branch March 25, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants