Preload standard library in ModuleInterfaceBuilder #36594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two weird bugs in -verify mode: 1. SourceLocs from the wrong SourceManager could be passed through a ForwardingDiagnosticConsumer into the DiagnosticVerifier. 2. -verify-additional-file did not error out correctly when the file couldn’t be opened. No tests, as we only have basic tests for the diagnostic verifier.
|
@swift-ci please smoke test |
nkcsgexi
approved these changes
Mar 26, 2021
Previously, when the standard library module interface was broken, Swift would try to rebuild it repeatedly during -compile-module-from-interface jobs because `ASTContext::getStdlibModule()` would try to load the standard library again each time it was called. This led to extremely slow compilations that repeatedly emitted the same errors. To avoid this, we make ModuleInterfaceBuilder try to load the standard library right away and bail out if it can’t. Fixes rdar://75669548.
beccadax
force-pushed
the
nonstandard-library
branch
from
8a59fd8 to
02c7476
Compare
|
@swift-ci please smoke test |
|
(Test needed to be tweaked for Windows.) |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test Linux platform |
|
This swift-driver error should have been cleared by swiftlang/swift-driver#571... @swift-ci please clean smoke test Linux platform |
|
@swift-ci please clean smoke test Linux platform |
|
@swift-ci please smoke test windows platform |
|
@swift-ci please smoke test |
|
I'm going to end up disabling the test on Windows, but I want to have information about the failure to file a bug. @swift-ci please smoke test windows platform |
|
@swift-ci please smoke test |
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Apr 16, 2021
swiftlang#36928 changed the error message while swiftlang#36594 added a test case looking for the old error message. Update the test to look for the non-dynamic substring of the new error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the standard library module interface was broken, Swift would try to rebuild it repeatedly during
-compile-module-from-interfacejobs becauseASTContext::getStdlibModule()would try to load the standard library again each time it was called. This led to extremely slow compilations that repeatedly emitted the same errors, and sometimes to crashes in non-asserts compilers when they expected a standard library but couldn't find one.To avoid this, we make
ModuleInterfaceBuildertry to load the standard library right away and bail out if it can’t.This PR also includes a couple of fixes for issues that occur when trying to use
-verifymode with module interfaces. One of these (the SourceLoc translation issue) is implicitly exercised by the new test; the other is a simple command-line flag validation bug.Fixes rdar://75669548.