Skip to content

GSB: Use explicit requirement list in enumerateRequirements() #36598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 27, 2021
Merged

GSB: Use explicit requirement list in enumerateRequirements() #36598

merged 5 commits into from
Mar 27, 2021

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Mar 26, 2021 •
edited
Loading

This is a follow-up to #36576.

@slavapestov slavapestov force-pushed the enumerate-requirements-explicitly branch from 25b29a9 to 41a57b3 Compare March 26, 2021 03:07
@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
GSB: Use a SmallSetVector to store the explicit requirements
7442e3a 
We can literally have duplicate requirements (same source and RHS)
when abstract signatures are built from scratch. They're not
flagged as "redundant" since there's no way to distinguish them
in the requirement graph, so just filter them out entirely.
@slavapestov
GSB: Assert that concrete types should not have any other requirements
389a082 
This sort of thing is not valid and should never happen:

    <T where T : P, T == Int>
@slavapestov
GSB: Fix bug with concrete same-type requirements to self-conforming …
74b29ca 
…protocols

If a type parameter both conformed to Error and was required to equal
Error, we didn't record a concrete source for the Error conformance.

This still produced the right minimized signature because the code in
enumerateRequirements() happens to skip all other requirements if an
equivalence class was concrete, but we shouldn't rely on that.

The bug also meant that we didn't diagnose the redundant conformance
requirement.
@slavapestov
GSB: Use explicit requirement list in enumerateRequirements()
a7f2e5c
@slavapestov
GSB: Skip same-type requirement minimization if there are no same-typ…
524e588 
…e requirements

The logic here is pretty expensive, and there's no reason to
do it at all if we aren't going to end up with any same-type
requirements.
@slavapestov slavapestov force-pushed the enumerate-requirements-explicitly branch from 41a57b3 to 524e588 Compare March 26, 2021 05:29
@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please test compiler performance

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@swift-ci
Copy link
Contributor

Summary for main full

Unexpected test results, excluded stats for RxCocoa

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 64,265,282,475,962 64,054,735,820,819 -210,546,655,143 -0.33%
LLVM.NumLLVMBytesOutput 2,411,631,052 2,411,635,772 4,720 0.0%
time.swift-driver.wall 5716.0s 5666.9s -49.1s -0.86%

debug-batch detailed

Regressed (1)
name old new delta delta_pct
Driver.NumDriverPipeReads 117,311 118,586 1,275 1.09% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (264)
name old new delta delta_pct
AST.ImportSetCacheHit 2,656,404 2,656,636 232 0.01%
AST.ImportSetCacheMiss 531,178 531,192 14 0.0%
AST.ImportSetFoldHit 162,713 162,723 10 0.01%
AST.ImportSetFoldMiss 368,464 368,468 4 0.0%
AST.ModuleShadowCacheHit 5,492 5,492 0 0.0%
AST.ModuleShadowCacheMiss 2,472 2,472 0 0.0%
AST.ModuleVisibilityCacheHit 62,510 62,510 0 0.0%
AST.ModuleVisibilityCacheMiss 10,241 10,241 0 0.0%
AST.NumASTBytesAllocated 62,361,425,356 62,189,001,814 -172,423,542 -0.28%
AST.NumASTScopeExpansions 7,529,596 7,529,603 7 0.0%
AST.NumASTScopeLookups 7,791,119 7,791,071 -48 -0.0%
AST.NumDecls 194,158 194,158 0 0.0%
AST.NumDependencies 426,724 426,720 -4 -0.0%
AST.NumIncrementalDependencies 17,886 17,886 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 341,420 341,420 0 0.0%
AST.NumLocalTypeDecls 317 317 0 0.0%
AST.NumModuleLookupClassMember 8,258 8,258 0 0.0%
AST.NumModuleLookupValue 69,178,011 69,183,163 5,152 0.01%
AST.NumObjCMethods 30,188 30,188 0 0.0%
AST.NumOperators 810 810 0 0.0%
AST.NumPrecedenceGroups 136 136 0 0.0%
AST.NumReferencedDynamicNames 206 206 0 0.0%
AST.NumReferencedMemberNames 14,004,348 14,004,347 -1 -0.0%
AST.NumReferencedTopLevelNames 1,433,211 1,433,211 0 0.0%
AST.NumSourceBuffers 398,144 398,144 0 0.0%
AST.NumSourceLines 6,444,690 6,444,690 0 0.0%
AST.NumSourceLinesPerSecond 6,172,453 6,202,712 30,259 0.49%
AST.NumTotalClangImportedEntities 4,828,412 4,828,044 -368 -0.01%
Driver.ChildrenMaxRSS 330,524,631,040 330,342,998,016 -181,633,024 -0.05%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 35,658 35,658 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumDriverPipePolls 129,521 130,820 1,299 1.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 1,021,478,882,320 1,022,572,110,832 1,093,228,512 0.11%
Frontend.NumInstructionsExecuted 64,265,282,475,962 64,054,735,820,819 -210,546,655,143 -0.33%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 33,898 33,898 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 326,471 326,471 0 0.0%
IRModule.NumIRAliases 264,187 264,187 0 0.0%
IRModule.NumIRBasicBlocks 10,526,196 10,526,196 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 4,806,558 4,806,558 0 0.0%
IRModule.NumIRGlobals 4,723,344 4,723,344 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 108,087,328 108,087,328 0 0.0%
IRModule.NumIRNamedMetaData 171,710 171,710 0 0.0%
IRModule.NumIRValueSymbols 8,870,054 8,870,054 0 0.0%
LLVM.NumLLVMBytesOutput 2,411,631,052 2,411,635,772 4,720 0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 382,201 382,201 0 0.0%
Parse.NumIterableDeclContextParsed 741,426 741,426 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 358,951 358,951 0 0.0%
Parse.ParseMembersRequest 1,116,177 1,116,177 0 0.0%
Parse.ParseSourceFileRequest 385,951 385,951 0 0.0%
SILGen.ASTLoweringRequest 35,603 35,603 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 3,118,225 3,118,225 0 0.0%
SILModule.NumSILGenGlobalVariables 88,850 88,850 0 0.0%
SILModule.NumSILGenVtables 38,916 38,916 0 0.0%
SILModule.NumSILGenWitnessTables 187,769 187,769 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 3,842,448 3,842,448 0 0.0%
SILModule.NumSILOptGlobalVariables 91,240 91,240 0 0.0%
SILModule.NumSILOptVtables 39,064 39,064 0 0.0%
SILModule.NumSILOptWitnessTables 253,044 253,044 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 137,363 137,363 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 33,266 33,266 0 0.0%
Sema.AbstractGenericSignatureRequest 48,124 48,124 0 0.0%
Sema.AccessLevelRequest 20,489,911 20,491,124 1,213 0.01%
Sema.ActorIsolationRequest 1,453,409 1,453,409 0 0.0%
Sema.AllMembersRequest 250,952 250,952 0 0.0%
Sema.AnyObjectLookupRequest 302 302 0 0.0%
Sema.ApplyAccessNoteRequest 2,873,321 2,873,360 39 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 28,709 28,709 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 15,674 15,674 0 0.0%
Sema.AttachedPropertyWrappersRequest 187,750,103 187,757,671 7,568 0.0%
Sema.AttachedResultBuilderRequest 974,295 974,295 0 0.0%
Sema.BodyInitKindRequest 66,586 66,586 0 0.0%
Sema.CallerSideDefaultArgExprRequest 133,094 133,094 0 0.0%
Sema.CanBeAsyncHandlerRequest 0 0 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 11,370 11,370 0 0.0%
Sema.CheckRedeclarationRequest 1,378,103 1,378,103 0 0.0%
Sema.ClassAncestryFlagsRequest 132,648 132,648 0 0.0%
Sema.ClosureHasExplicitResultRequest 129,202 129,202 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 12,428,829 12,429,488 659 0.01%
Sema.CompareDeclSpecializationRequest 680,215 680,611 396 0.06%
Sema.ConditionalRequirementsRequest 679,668 679,700 32 0.0%
Sema.ConformanceHasEffectRequest 0 0 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 2,053 2,053 0 0.0%
Sema.CustomAttrTypeRequest 807 807 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 78,675 78,675 0 0.0%
Sema.DefaultArgumentExprRequest 52,802 52,802 0 0.0%
Sema.DefaultArgumentInitContextRequest 350 350 0 0.0%
Sema.DefaultDefinitionTypeRequest 9,341 9,341 0 0.0%
Sema.DefaultTypeRequest 378,602 378,602 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 16 16 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 50,006,181 50,009,774 3,593 0.01%
Sema.DirectOperatorLookupRequest 2,537,981 2,538,115 134 0.01%
Sema.DirectPrecedenceGroupLookupRequest 803,234 803,234 0 0.0%
Sema.DynamicallyReplacedDeclRequest 1,523,717 1,523,717 0 0.0%
Sema.EnumRawTypeRequest 32,779 32,779 0 0.0%
Sema.EnumRawValuesRequest 15,739 15,739 0 0.0%
Sema.ExistentialConformsToSelfRequest 23,678 23,679 1 0.0%
Sema.ExistentialTypeSupportedRequest 21,543 21,543 0 0.0%
Sema.ExtendedNominalRequest 680,285 680,285 0 0.0%
Sema.ExtendedTypeRequest 103,633 103,633 0 0.0%
Sema.FragileFunctionKindRequest 2,122,484 2,122,484 0 0.0%
Sema.FunctionOperatorRequest 73,607 73,607 0 0.0%
Sema.GenericParamListRequest 6,371,009 6,371,926 917 0.01%
Sema.GenericSignatureRequest 3,561,599 3,561,985 386 0.01%
Sema.GetDestructorRequest 32,882 32,882 0 0.0%
Sema.GetImplicitSendableRequest 294,053 294,497 444 0.15%
Sema.GlobalActorAttributeRequest 1,738,409 1,738,409 0 0.0%
Sema.GlobalActorInstanceRequest 202 202 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 13,755 13,755 0 0.0%
Sema.HasCircularRawValueRequest 13,572 13,572 0 0.0%
Sema.HasDefaultInitRequest 72,272 72,272 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 759,652 759,728 76 0.01%
Sema.HasImplementationOnlyImportsRequest 381,778 381,778 0 0.0%
Sema.HasMemberwiseInitRequest 31,359 31,359 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 31,434 31,434 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 72,284 72,284 0 0.0%
Sema.InferredGenericSignatureRequest 205,032 205,032 0 0.0%
Sema.InheritedDeclsReferencedRequest 8,111,396 8,114,505 3,109 0.04%
Sema.InheritedProtocolsRequest 737,527 737,763 236 0.03%
Sema.InheritedTypeRequest 343,532 343,658 126 0.04%
Sema.InheritsSuperclassInitializersRequest 34,349 34,349 0 0.0%
Sema.InitKindRequest 125,682 125,682 0 0.0%
Sema.InterfaceTypeRequest 20,624,731 20,627,601 2,870 0.01%
Sema.IsABICompatibleOverrideRequest 186,493 186,493 0 0.0%
Sema.IsAccessorTransparentRequest 446,832 446,832 0 0.0%
Sema.IsActorRequest 614,975 615,082 107 0.02%
Sema.IsAsyncHandlerRequest 1,981,197 1,981,305 108 0.01%
Sema.IsCallableNominalTypeRequest 3,427 3,427 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 50,639 50,639 0 0.0%
Sema.IsDefaultActorRequest 55,409 55,409 0 0.0%
Sema.IsDynamicRequest 2,422,362 2,422,362 0 0.0%
Sema.IsFinalRequest 3,728,486 3,730,663 2,177 0.06%
Sema.IsGetterMutatingRequest 583,445 583,445 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 3,370,992 3,370,330 -662 -0.02%
Sema.IsObjCRequest 2,132,139 2,132,178 39 0.0%
Sema.IsSetterMutatingRequest 479,453 479,453 0 0.0%
Sema.IsStaticRequest 2,718,862 2,718,761 -101 -0.0%
Sema.LazyStoragePropertyRequest 2,916 2,916 0 0.0%
Sema.LookupAllConformancesInContextRequest 2,458,029 2,458,493 464 0.02%
Sema.LookupConformanceInModuleRequest 56,390,086 56,380,653 -9,433 -0.02%
Sema.LookupInModuleRequest 8,735,994 8,740,407 4,413 0.05%
Sema.LookupInfixOperatorRequest 109,283 109,283 0 0.0%
Sema.LookupPostfixOperatorRequest 187 187 0 0.0%
Sema.LookupPrecedenceGroupRequest 35,137 35,137 0 0.0%
Sema.LookupPrefixOperatorRequest 897 897 0 0.0%
Sema.MangleLocalTypeDeclRequest 634 634 0 0.0%
Sema.ModuleImplicitImportsRequest 13,053 13,053 0 0.0%
Sema.ModuleQualifiedLookupRequest 4,133,504 4,137,965 4,461 0.11%
Sema.NamedLazyMemberLoadSuccessCount 27,677,247 27,678,718 1,471 0.01%
Sema.NamingPatternRequest 308,499 308,499 0 0.0%
Sema.NeedsNewVTableEntryRequest 950,784 950,784 0 0.0%
Sema.NumAccessorBodiesSynthesized 277,643 277,643 0 0.0%
Sema.NumAccessorsSynthesized 408,472 408,472 0 0.0%
Sema.NumConformancesDeserialized 13,602,942 13,607,047 4,105 0.03%
Sema.NumConstraintScopes 33,349,637 33,350,266 629 0.0%
Sema.NumConstraintsConsideredForEdgeContraction 3,219,237 3,219,237 0 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 554 554 0 0.0%
Sema.NumDeclsDeserialized 105,267,643 105,287,334 19,691 0.02%
Sema.NumDeclsTypechecked 1,977,127 1,977,127 0 0.0%
Sema.NumGenericSignatureBuilders 1,583,638 1,584,475 837 0.05%
Sema.NumLazyIterableDeclContexts 11,574,154 11,576,296 2,142 0.02%
Sema.NumLazyRequirementSignatures 1,083,748 1,083,794 46 0.0%
Sema.NumLazyRequirementSignaturesLoaded 747,515 747,619 104 0.01%
Sema.NumLeafScopes 21,654,568 21,654,951 383 0.0%
Sema.NumTypesDeserialized 31,502,515 31,513,067 10,552 0.03%
Sema.NumUnloadedLazyIterableDeclContexts 6,640,686 6,641,926 1,240 0.02%
Sema.OpaqueReadOwnershipRequest 376,889 376,889 0 0.0%
Sema.OpaqueResultTypeRequest 423 423 0 0.0%
Sema.OperatorPrecedenceGroupRequest 933 933 0 0.0%
Sema.OverriddenDeclsRequest 3,810,935 3,810,539 -396 -0.01%
Sema.ParamSpecifierRequest 1,680,102 1,680,102 0 0.0%
Sema.PatternBindingEntryRequest 654,593 654,593 0 0.0%
Sema.PatternTypeRequest 765,060 765,060 0 0.0%
Sema.PolymorphicEffectKindRequest 154,680 154,680 0 0.0%
Sema.PolymorphicEffectRequirementsRequest 0 0 0 0.0%
Sema.PreCheckResultBuilderRequest 962 962 0 0.0%
Sema.PrimarySourceFilesRequest 13,053 13,053 0 0.0%
Sema.PropertyWrapperAuxiliaryVariablesRequest 1,946,485 1,946,485 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 15,674 15,674 0 0.0%
Sema.PropertyWrapperInitializerInfoRequest 487,501 487,501 0 0.0%
Sema.PropertyWrapperLValuenessRequest 646 646 0 0.0%
Sema.PropertyWrapperMutabilityRequest 826,476 826,476 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 221 221 0 0.0%
Sema.ProtocolRequiresClassRequest 48,204 48,291 87 0.18%
Sema.ProvideDefaultImplForRequest 12,428,829 12,429,488 659 0.01%
Sema.QualifiedLookupRequest 8,549,987 8,550,438 451 0.01%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 131,891 131,849 -42 -0.03%
Sema.RequirementSignatureRequest 824,647 824,875 228 0.03%
Sema.RequiresOpaqueAccessorsRequest 1,785,675 1,785,675 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 359,447 359,447 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 612,364 612,332 -32 -0.01%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 4,351,060 4,350,976 -84 -0.0%
Sema.ResultBuilderTypeRequest 497,262 497,262 0 0.0%
Sema.ResultTypeRequest 900,041 900,041 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 8,219,724 8,220,986 1,262 0.02%
Sema.ScopedImportLookupRequest 1,173 1,173 0 0.0%
Sema.SelfAccessKindRequest 986,715 986,703 -12 -0.0%
Sema.SelfBoundsFromWhereClauseRequest 2,130,996 2,132,861 1,865 0.09%
Sema.SetterAccessLevelRequest 216,112 216,112 0 0.0%
Sema.SimpleDidSetRequest 3,348,236 3,347,901 -335 -0.01%
Sema.SpecializeAttrTargetDeclRequest 5,075 5,075 0 0.0%
Sema.StorageImplInfoRequest 2,043,710 2,043,710 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 82,451 82,451 0 0.0%
Sema.StoredPropertiesRequest 454,220 454,220 0 0.0%
Sema.StructuralTypeRequest 2,426 2,426 0 0.0%
Sema.SuperclassDeclRequest 567,155 567,314 159 0.03%
Sema.SuperclassTypeRequest 66,367 66,369 2 0.0%
Sema.SynthesizeAccessorRequest 408,472 408,472 0 0.0%
Sema.SynthesizeDefaultInitRequest 7,157 7,157 0 0.0%
Sema.SynthesizeMainFunctionRequest 134,499 134,499 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 5,454 5,454 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckCompletionHandlerAsyncAttrRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 731,513 731,513 0 0.0%
Sema.TypeCheckSourceFileRequest 34,342 34,342 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 36,620 36,620 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 11,167 11,167 0 0.0%
Sema.USRGenerationRequest 14,409,122 14,410,415 1,293 0.01%
Sema.UnderlyingTypeDeclsReferencedRequest 416,096 416,199 103 0.02%
Sema.UnderlyingTypeRequest 48,326 48,326 0 0.0%
Sema.UnqualifiedLookupRequest 5,567,110 5,567,062 -48 -0.0%
Sema.ValidatePrecedenceGroupRequest 254,594 254,594 0 0.0%
Sema.ValueWitnessRequest 87,951 87,951 0 0.0%
TBDGen.APIGenRequest 0 0 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 33,920 33,920 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
time.swift-driver.wall 9131.6s 9013.3s -118.3s -1.3% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 70,047,463,858,517 69,887,740,777,195 -159,723,081,322 -0.23%
LLVM.NumLLVMBytesOutput 2,425,440,776 2,425,474,968 34,192 0.0%

release detailed

Regressed (3)
name old new delta delta_pct
AST.NumSourceLinesPerSecond 707,237 718,831 11,594 1.64% ⛔
Driver.NumDriverPipePolls 48,439 49,361 922 1.9% ⛔
Driver.NumDriverPipeReads 46,393 47,315 922 1.99% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (262)
name old new delta delta_pct
AST.ImportSetCacheHit 1,760,390 1,760,390 0 0.0%
AST.ImportSetCacheMiss 81,274 81,274 0 0.0%
AST.ImportSetFoldHit 33,924 33,924 0 0.0%
AST.ImportSetFoldMiss 47,350 47,350 0 0.0%
AST.ModuleShadowCacheHit 4,658 4,658 0 0.0%
AST.ModuleShadowCacheMiss 1,778 1,778 0 0.0%
AST.ModuleVisibilityCacheHit 39,846 39,846 0 0.0%
AST.ModuleVisibilityCacheMiss 4,645 4,645 0 0.0%
AST.NumASTBytesAllocated 13,417,799,452 13,318,220,772 -99,578,680 -0.74%
AST.NumASTScopeExpansions 4,028,311 4,028,311 0 0.0%
AST.NumASTScopeLookups 5,853,049 5,853,049 0 0.0%
AST.NumDecls 196,810 196,810 0 0.0%
AST.NumDependencies 75,550 75,535 -15 -0.02%
AST.NumIncrementalDependencies 0 0 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 39,246 39,246 0 0.0%
AST.NumLocalTypeDecls 317 317 0 0.0%
AST.NumModuleLookupClassMember 7,956 7,956 0 0.0%
AST.NumModuleLookupValue 38,116,568 38,116,568 0 0.0%
AST.NumObjCMethods 29,924 29,924 0 0.0%
AST.NumOperators 810 810 0 0.0%
AST.NumPrecedenceGroups 136 136 0 0.0%
AST.NumReferencedDynamicNames 0 0 0 0.0%
AST.NumReferencedMemberNames 3,976 3,976 0 0.0%
AST.NumReferencedTopLevelNames 352 352 0 0.0%
AST.NumSourceBuffers 40,801 40,801 0 0.0%
AST.NumSourceLines 6,531,633 6,531,633 0 0.0%
AST.NumTotalClangImportedEntities 642,372 642,372 0 0.0%
Driver.ChildrenMaxRSS 439,954,673,664 439,975,843,840 21,170,176 0.0%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 2,046 2,046 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 332,767,210,336 332,731,110,920 -36,099,416 -0.01%
Frontend.NumInstructionsExecuted 70,047,463,858,517 69,887,740,777,195 -159,723,081,322 -0.23%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 12 12 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 316,642 316,642 0 0.0%
IRModule.NumIRAliases 210,100 210,100 0 0.0%
IRModule.NumIRBasicBlocks 6,579,535 6,579,535 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 3,808,968 3,808,968 0 0.0%
IRModule.NumIRGlobals 4,276,604 4,276,604 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 63,203,916 63,203,916 0 0.0%
IRModule.NumIRNamedMetaData 174,900 174,900 0 0.0%
IRModule.NumIRValueSymbols 7,728,865 7,728,865 0 0.0%
LLVM.NumLLVMBytesOutput 2,425,440,776 2,425,474,968 34,192 0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 387,183 387,183 0 0.0%
Parse.NumIterableDeclContextParsed 131,558 131,558 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 361,013 361,013 0 0.0%
Parse.ParseMembersRequest 682 682 0 0.0%
Parse.ParseSourceFileRequest 35,004 35,004 0 0.0%
SILGen.ASTLoweringRequest 1,730 1,730 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,728,491 1,728,491 0 0.0%
SILModule.NumSILGenGlobalVariables 88,788 88,788 0 0.0%
SILModule.NumSILGenVtables 23,745 23,745 0 0.0%
SILModule.NumSILGenWitnessTables 99,254 99,254 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 1,416,451 1,416,451 0 0.0%
SILModule.NumSILOptGlobalVariables 65,227 65,227 0 0.0%
SILModule.NumSILOptVtables 29,000 29,000 0 0.0%
SILModule.NumSILOptWitnessTables 101,645 101,645 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 6,908 6,908 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 24,887 24,887 0 0.0%
Sema.AbstractGenericSignatureRequest 36,716 36,716 0 0.0%
Sema.AccessLevelRequest 2,197,861 2,197,861 0 0.0%
Sema.ActorIsolationRequest 927,693 927,693 0 0.0%
Sema.AllMembersRequest 128,139 128,139 0 0.0%
Sema.AnyObjectLookupRequest 302 302 0 0.0%
Sema.ApplyAccessNoteRequest 2,270,134 2,270,134 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 19,141 19,141 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 10,035 10,035 0 0.0%
Sema.AttachedPropertyWrappersRequest 153,285,592 153,285,592 0 0.0%
Sema.AttachedResultBuilderRequest 946,176 946,176 0 0.0%
Sema.BodyInitKindRequest 65,320 65,320 0 0.0%
Sema.CallerSideDefaultArgExprRequest 133,073 133,073 0 0.0%
Sema.CanBeAsyncHandlerRequest 0 0 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 1,726 1,726 0 0.0%
Sema.CheckRedeclarationRequest 1,400,319 1,400,319 0 0.0%
Sema.ClassAncestryFlagsRequest 64,338 64,338 0 0.0%
Sema.ClosureHasExplicitResultRequest 128,458 128,458 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 0 0 0 0.0%
Sema.CompareDeclSpecializationRequest 532,016 532,016 0 0.0%
Sema.ConditionalRequirementsRequest 257,494 257,494 0 0.0%
Sema.ConformanceHasEffectRequest 0 0 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 533 533 0 0.0%
Sema.CustomAttrTypeRequest 373 373 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 56,539 56,539 0 0.0%
Sema.DefaultArgumentExprRequest 53,213 53,213 0 0.0%
Sema.DefaultArgumentInitContextRequest 126 126 0 0.0%
Sema.DefaultDefinitionTypeRequest 4,092 4,092 0 0.0%
Sema.DefaultTypeRequest 365,850 365,850 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 8 8 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 43,029,255 43,029,248 -7 -0.0%
Sema.DirectOperatorLookupRequest 1,569,607 1,569,607 0 0.0%
Sema.DirectPrecedenceGroupLookupRequest 751,479 751,479 0 0.0%
Sema.DynamicallyReplacedDeclRequest 1,122,296 1,122,296 0 0.0%
Sema.EnumRawTypeRequest 13,651 13,651 0 0.0%
Sema.EnumRawValuesRequest 14,461 14,461 0 0.0%
Sema.ExistentialConformsToSelfRequest 6,815 6,815 0 0.0%
Sema.ExistentialTypeSupportedRequest 11,134 11,134 0 0.0%
Sema.ExtendedNominalRequest 61,527 61,527 0 0.0%
Sema.ExtendedTypeRequest 61,495 61,495 0 0.0%
Sema.FragileFunctionKindRequest 1,419,550 1,419,550 0 0.0%
Sema.FunctionOperatorRequest 12,511 12,511 0 0.0%
Sema.GenericParamListRequest 1,668,680 1,668,680 0 0.0%
Sema.GenericSignatureRequest 1,420,124 1,420,124 0 0.0%
Sema.GetDestructorRequest 24,683 24,683 0 0.0%
Sema.GetImplicitSendableRequest 57,552 57,552 0 0.0%
Sema.GlobalActorAttributeRequest 1,149,538 1,149,538 0 0.0%
Sema.GlobalActorInstanceRequest 61 61 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 11,512 11,512 0 0.0%
Sema.HasCircularRawValueRequest 13,650 13,650 0 0.0%
Sema.HasDefaultInitRequest 42,315 42,315 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 349,888 349,888 0 0.0%
Sema.HasImplementationOnlyImportsRequest 34,841 34,841 0 0.0%
Sema.HasMemberwiseInitRequest 18,578 18,578 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 25,646 25,646 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 42,315 42,315 0 0.0%
Sema.InferredGenericSignatureRequest 91,562 91,562 0 0.0%
Sema.InheritedDeclsReferencedRequest 1,513,020 1,513,020 0 0.0%
Sema.InheritedProtocolsRequest 135,620 135,620 0 0.0%
Sema.InheritedTypeRequest 209,530 209,530 0 0.0%
Sema.InheritsSuperclassInitializersRequest 18,664 18,664 0 0.0%
Sema.InitKindRequest 80,960 80,960 0 0.0%
Sema.InterfaceTypeRequest 4,500,635 4,500,635 0 0.0%
Sema.IsABICompatibleOverrideRequest 186,187 186,187 0 0.0%
Sema.IsAccessorTransparentRequest 372,689 372,689 0 0.0%
Sema.IsActorRequest 166,051 166,051 0 0.0%
Sema.IsAsyncHandlerRequest 990,362 990,362 0 0.0%
Sema.IsCallableNominalTypeRequest 2,958 2,958 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 31,940 31,940 0 0.0%
Sema.IsDefaultActorRequest 34,892 34,892 0 0.0%
Sema.IsDynamicRequest 1,736,209 1,736,209 0 0.0%
Sema.IsFinalRequest 1,372,106 1,372,106 0 0.0%
Sema.IsGetterMutatingRequest 453,305 453,305 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,643,472 2,643,472 0 0.0%
Sema.IsObjCRequest 1,515,753 1,515,753 0 0.0%
Sema.IsSetterMutatingRequest 436,516 436,516 0 0.0%
Sema.IsStaticRequest 783,961 783,961 0 0.0%
Sema.LazyStoragePropertyRequest 878 878 0 0.0%
Sema.LookupAllConformancesInContextRequest 146,130 146,130 0 0.0%
Sema.LookupConformanceInModuleRequest 89,905,215 89,904,966 -249 -0.0%
Sema.LookupInModuleRequest 3,086,371 3,086,371 0 0.0%
Sema.LookupInfixOperatorRequest 74,777 74,777 0 0.0%
Sema.LookupPostfixOperatorRequest 47 47 0 0.0%
Sema.LookupPrecedenceGroupRequest 34,365 34,365 0 0.0%
Sema.LookupPrefixOperatorRequest 186 186 0 0.0%
Sema.MangleLocalTypeDeclRequest 337 337 0 0.0%
Sema.ModuleImplicitImportsRequest 1,730 1,730 0 0.0%
Sema.ModuleQualifiedLookupRequest 573,901 573,901 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 11,331,546 11,331,441 -105 -0.0%
Sema.NamingPatternRequest 96,158 96,158 0 0.0%
Sema.NeedsNewVTableEntryRequest 762,625 762,625 0 0.0%
Sema.NumAccessorBodiesSynthesized 282,016 282,016 0 0.0%
Sema.NumAccessorsSynthesized 286,587 286,587 0 0.0%
Sema.NumConformancesDeserialized 4,570,067 4,570,067 0 0.0%
Sema.NumConstraintScopes 32,211,714 32,211,687 -27 -0.0%
Sema.NumConstraintsConsideredForEdgeContraction 3,208,546 3,208,546 0 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 554 554 0 0.0%
Sema.NumDeclsDeserialized 15,986,652 15,986,653 1 0.0%
Sema.NumDeclsTypechecked 2,008,034 2,008,034 0 0.0%
Sema.NumGenericSignatureBuilders 308,989 309,101 112 0.04%
Sema.NumLazyIterableDeclContexts 1,932,467 1,932,467 0 0.0%
Sema.NumLazyRequirementSignatures 163,096 163,096 0 0.0%
Sema.NumLazyRequirementSignaturesLoaded 125,038 125,038 0 0.0%
Sema.NumLeafScopes 20,796,805 20,796,787 -18 -0.0%
Sema.NumTypesDeserialized 7,096,495 7,096,495 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 1,230,067 1,230,066 -1 -0.0%
Sema.OpaqueReadOwnershipRequest 255,486 255,486 0 0.0%
Sema.OpaqueResultTypeRequest 356 356 0 0.0%
Sema.OperatorPrecedenceGroupRequest 720 720 0 0.0%
Sema.OverriddenDeclsRequest 1,471,834 1,471,834 0 0.0%
Sema.ParamSpecifierRequest 1,083,190 1,083,190 0 0.0%
Sema.PatternBindingEntryRequest 425,216 425,216 0 0.0%
Sema.PatternTypeRequest 533,641 533,641 0 0.0%
Sema.PolymorphicEffectKindRequest 97,302 97,302 0 0.0%
Sema.PolymorphicEffectRequirementsRequest 0 0 0 0.0%
Sema.PreCheckResultBuilderRequest 888 888 0 0.0%
Sema.PrimarySourceFilesRequest 1,730 1,730 0 0.0%
Sema.PropertyWrapperAuxiliaryVariablesRequest 1,668,304 1,668,304 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 10,035 10,035 0 0.0%
Sema.PropertyWrapperInitializerInfoRequest 486,559 486,559 0 0.0%
Sema.PropertyWrapperLValuenessRequest 646 646 0 0.0%
Sema.PropertyWrapperMutabilityRequest 691,445 691,445 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 62 62 0 0.0%
Sema.ProtocolRequiresClassRequest 12,071 12,071 0 0.0%
Sema.ProvideDefaultImplForRequest 0 0 0 0.0%
Sema.QualifiedLookupRequest 5,320,627 5,320,627 0 0.0%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 90,124 90,124 0 0.0%
Sema.RequirementSignatureRequest 139,162 139,162 0 0.0%
Sema.RequiresOpaqueAccessorsRequest 1,602,171 1,602,171 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 252,342 252,342 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 472,743 472,743 0 0.0%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 2,551,135 2,551,135 0 0.0%
Sema.ResultBuilderTypeRequest 463,274 463,274 0 0.0%
Sema.ResultTypeRequest 568,882 568,882 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 2,562,008 2,562,008 0 0.0%
Sema.ScopedImportLookupRequest 1,267 1,267 0 0.0%
Sema.SelfAccessKindRequest 441,880 441,880 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 603,752 603,752 0 0.0%
Sema.SetterAccessLevelRequest 183,594 183,594 0 0.0%
Sema.SimpleDidSetRequest 464,653 464,653 0 0.0%
Sema.SpecializeAttrTargetDeclRequest 2,923 2,923 0 0.0%
Sema.StorageImplInfoRequest 1,748,356 1,748,356 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 57,193 57,193 0 0.0%
Sema.StoredPropertiesRequest 203,811 203,811 0 0.0%
Sema.StructuralTypeRequest 698 698 0 0.0%
Sema.SuperclassDeclRequest 136,336 136,336 0 0.0%
Sema.SuperclassTypeRequest 32,708 32,708 0 0.0%
Sema.SynthesizeAccessorRequest 286,587 286,587 0 0.0%
Sema.SynthesizeDefaultInitRequest 4,233 4,233 0 0.0%
Sema.SynthesizeMainFunctionRequest 128,119 128,119 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,631 3,631 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckCompletionHandlerAsyncAttrRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 739,622 739,622 0 0.0%
Sema.TypeCheckSourceFileRequest 34,980 34,980 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 28,682 28,682 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 5,213 5,213 0 0.0%
Sema.USRGenerationRequest 546,740 546,740 0 0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 77,710 77,710 0 0.0%
Sema.UnderlyingTypeRequest 26,445 26,445 0 0.0%
Sema.UnqualifiedLookupRequest 3,028,107 3,028,107 0 0.0%
Sema.ValidatePrecedenceGroupRequest 254,949 254,949 0 0.0%
Sema.ValueWitnessRequest 44,929 44,929 0 0.0%
TBDGen.APIGenRequest 0 0 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 1,726 1,726 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

@slavapestov slavapestov merged commit 8f52c26 into swiftlang:main Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @swift-ci