Skip to content

[TypeChecker] NFC: Adjust scale thresholds and move to test-cases to "fast" #36635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2021
Merged

[TypeChecker] NFC: Adjust scale thresholds and move to test-cases to "fast" #36635

merged 2 commits into from
Mar 31, 2021

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Mar 29, 2021

Resolves: SR-6520

@xedin
Copy link
Contributor Author

xedin commented Mar 29, 2021

/cc @hborla Looks like both of them didn't use --invert-results and are under 1.7 threshold, so I have increased scale to 20 (from 5).

@xedin
Copy link
Contributor Author

xedin commented Mar 29, 2021

@swift-ci please test macOS

@xedin
Copy link
Contributor Author

xedin commented Mar 29, 2021

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d155b5c

@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

@swift-ci please test macOS platform

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d155b5c

@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

@swift-ci please test macOS platform

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

@swift-ci please test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

@lorentey and @shahmishal There might be an issue with https://ci.swift.org/computer/macOS-28

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d155b5c

@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

@swift-ci please test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

@swift-ci please smoke test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d155b5c

@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

@swift-ci please test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

🤞

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d155b5c

@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

@swift-ci please clean test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Mar 30, 2021

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d155b5c

@xedin xedin merged commit d196842 into swiftlang:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @swift-ci