[Sanitizer] Disable tests that depend on symbolication on watchOS #36638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some new Sanitizer tests are failing on watchOS because we fail to start atos to symbolicate the report. FileCheck then fails when we assert on the generated report. Radar-Id: rdar://75766734
|
@swift-ci Please test and merge |
xedin
approved these changes
Mar 30, 2021
|
One unrelated test failure prevents me from merging: @xedin @nate-chandler @shahmishal Can you use your magic powers to merge this PR? Thanks! :) |
|
This is known test failure, we are working on disabling this test. |
|
@swift-ci Please test and merge |
|
@yln Don't we need to disable this for all the simulators? Not just the watch? |
Same test is failing again. @shahmishal Can you merge this for me? Thanks! |
It only seems to be failing on the watchOS simulator (also see radar). I have no explanation why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new Sanitizer tests are failing on watchOS because we fail to start
atos to symbolicate the report. FileCheck then fails when we assert on
the generated report.
Radar-Id: rdar://75766734